Adding template for AuthRules in EH #2378
Conversation
|
Hi @sazeesha, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
| @@ -0,0 +1,5 @@ | |||
| # 301-eventHub-create-authrule-namespace-and-eventHub | |||
There was a problem hiding this comment.
Need a better name rather than just template folder name here. Also is there a reason folder name isn't all lower-case?
There was a problem hiding this comment.
This doesn't seem like a 301 template, more like 201. There's only a few resources in this.
There was a problem hiding this comment.
Complexity of a template for our service is defined by the type of resource being created and not just the number. Besides there a lot going on in this template. eg: some resources need to be created serially and that needs the correct use of dependson property. A lot of customers have reported this issue and it needs to addressed via a template.
|
Can anyone review this? we have customers waiting for this template. |
|
Normally we'd ask that you use a raw string for apiVersion instead of a variable, but this case the user is passing in the apiVersion via parameter, so that advice doesn't really make sense; looks good; merging |
Contributing guide
https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md
Changelog
Description of the change